Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-4008: Promote CRD Ratcheting to GA #5082

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

KEP-4008: Promote CRD Ratcheting to GA #5082

wants to merge 1 commit into from

Conversation

yongruilin
Copy link

  • One-line PR description:
    KEP-4008: Promote CRD Ratcheting to GA
  • Other comments:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 23, 2025
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Jan 23, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yongruilin
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 23, 2025
@yongruilin
Copy link
Author

/cc @jpbetz @johnbelamaric

@jpbetz
Copy link
Contributor

jpbetz commented Jan 23, 2025

I support this. We've had this on-by-default for quite some time for all CRDs.

Any concerns @deads2k?

@sttts
Copy link
Contributor

sttts commented Jan 28, 2025

+1 from me. Have never heard of any issue with that, with exception of the status subresources issues that @JoelSpeed found and fixed recently.

@jpbetz jpbetz mentioned this pull request Jan 28, 2025
Open
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbetz jpbetz Awaiting requested review from jpbetz

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yongruilin @k8s-ci-robot @jpbetz @sttts