Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Go to v1.24 #17295

Merged
merged 2 commits into from
Mar 10, 2025
Merged

Bump Go to v1.24 #17295

merged 2 commits into from
Mar 10, 2025
+96 −70

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Mar 1, 2025

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 1, 2025
@ameukam
Copy link
Member Author

ameukam commented Mar 1, 2025

/hold

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 1, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2025
ameukam
ameukam commented Mar 1, 2025
View reviewed changes
ameukam
ameukam commented Mar 1, 2025
View reviewed changes
@ameukam ameukam changed the title Bump to Go 1.24 [WIP] Bump to Go 1.24 Mar 1, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 1, 2025
@ameukam ameukam force-pushed the go-1.24 branch 3 times, most recently from c6640ac to 61a4c58 Compare March 8, 2025 14:32
ameukam added 2 commits March 10, 2025 13:55
@ameukam
Bump to Go 1.24
f3191bd 
https://tip.golang.org/doc/go1.24

Signed-off-by: Arnaud Meukam <[email protected]>
@ameukam
Increase the key size for KubeConfig private key
1ed0cde 
It's now required to have a minimum of 1024 bits the RSA private key.
https://pkg.go.dev/crypto/rsa@master#GenerateKey.

Signed-off-by: Arnaud Meukam <[email protected]>
@k8s-ci-robot
Copy link
Contributor

@ameukam: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-kubernetes-e2e-ubuntu-gce-build 1ed0cde link false /test pull-kops-kubernetes-e2e-ubuntu-gce-build

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ameukam
Copy link
Member Author

ameukam commented Mar 10, 2025

/retest

@ameukam
Copy link
Member Author

ameukam commented Mar 10, 2025

/retitle Bump Go 1.24
/hold cancel
/assign @hakman @justinsb @rifelpet

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2025
@k8s-ci-robot k8s-ci-robot changed the title [WIP] Bump to Go 1.24 Bump Go 1.24 Mar 10, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 10, 2025
@hakman hakman changed the title Bump Go 1.24 Bump Go to v1.24 Mar 10, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2025
@k8s-ci-robot k8s-ci-robot merged commit 52833b5 into kubernetes:master Mar 10, 2025
26 of 27 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@johngmyers johngmyers Awaiting requested review from johngmyers

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@justinsb justinsb

@rifelpet rifelpet

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.
5 participants
@ameukam @k8s-ci-robot @hakman @justinsb @rifelpet