-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove jobs from sig-node-presubmits.yaml and generate them for dra-canary.yaml using jinja #34163
Open
elieser1101
wants to merge
1
commit into
kubernetes:master
Choose a base branch
from
elieser1101:generate-dra-kubetest-using-jinja
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+141
−111
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -254,3 +254,97 @@ presubmits: | |
| requests: | ||
| cpu: 2 | ||
| memory: 9Gi | ||
|
|
||
| - name: pull-kubernetes-node-e2e-crio-cgrpv1-dra-kubetest2-canary | ||
| cluster: k8s-infra-prow-build | ||
| skip_branches: | ||
| - release-\d+\.\d+ # per-release image | ||
| always_run: false | ||
| optional: true | ||
| labels: | ||
| preset-service-account: "true" | ||
| annotations: | ||
| testgrid-dashboards: sig-node-dynamic-resource-allocation, sig-node-presubmits, sig-node-cri-o | ||
| description: Runs E2E node tests for Dynamic Resource Allocation beta features with CRI-O using cgroup v1 | ||
| testgrid-alert-email: [email protected], [email protected] | ||
| decorate: true | ||
| decoration_config: | ||
| timeout: 25m # artificially low to test timeout handling, needs to be reverted | ||
| path_alias: k8s.io/kubernetes | ||
| spec: | ||
| containers: | ||
| - image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20241230-3006692a6f-master | ||
| command: | ||
| - runner.sh | ||
| args: | ||
| - kubetest2 | ||
| - noop | ||
| - --test=node | ||
| - -- | ||
| - --repo-root=. | ||
| - --gcp-zone=us-west1-b | ||
| - --parallelism=1 | ||
| - '--label-filter=Feature: containsAny DynamicResourceAllocation && Feature: isSubsetOf { Beta, DynamicResourceAllocation } && !Flaky && !Slow' | ||
| - '--test-args=--feature-gates="DynamicResourceAllocation=true" --service-feature-gates="DynamicResourceAllocation=true" --runtime-config=api/beta=true --container-runtime-endpoint=unix:///var/run/crio/crio.sock --container-runtime-process-name=/usr/local/bin/crio --container-runtime-pid-file= --kubelet-flags="--cgroup-driver=systemd --cgroups-per-qos=true --cgroup-root=/ --runtime-cgroups=/system.slice/crio.service --kubelet-cgroups=/system.slice/kubelet.service" --extra-log="{\"name\": \"crio.log\", \"journalctl\": [\"-u\", \"crio\"]}"' | ||
| - --image-config-file=/home/prow/go/src/k8s.io/test-infra/jobs/e2e_node/crio/latest/image-config-cgroupv1-serial.yaml | ||
| env: | ||
| - name: IGNITION_INJECT_GCE_SSH_PUBLIC_KEY_FILE | ||
| value: "1" | ||
| - name: GOPATH | ||
| value: /go | ||
| - name: KUBE_SSH_USER | ||
| value: core | ||
| resources: | ||
| limits: | ||
| cpu: 2 | ||
| memory: 9Gi | ||
| requests: | ||
| cpu: 2 | ||
| memory: 9Gi | ||
|
|
||
| - name: pull-kubernetes-node-e2e-crio-cgrpv2-dra-kubetest2-canary | ||
| cluster: k8s-infra-prow-build | ||
| skip_branches: | ||
| - release-\d+\.\d+ # per-release image | ||
| always_run: false | ||
| optional: true | ||
| labels: | ||
| preset-service-account: "true" | ||
| annotations: | ||
| testgrid-dashboards: sig-node-dynamic-resource-allocation, sig-node-presubmits, sig-node-cri-o | ||
| description: Runs E2E node tests for Dynamic Resource Allocation beta features with CRI-O using cgroup v2 | ||
| testgrid-alert-email: [email protected], [email protected] | ||
| decorate: true | ||
| decoration_config: | ||
| timeout: 25m # artificially low to test timeout handling, needs to be reverted | ||
| path_alias: k8s.io/kubernetes | ||
| spec: | ||
| containers: | ||
| - image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20241230-3006692a6f-master | ||
| command: | ||
| - runner.sh | ||
| args: | ||
| - kubetest2 | ||
| - noop | ||
| - --test=node | ||
| - -- | ||
| - --repo-root=. | ||
| - --gcp-zone=us-west1-b | ||
| - --parallelism=1 | ||
| - '--label-filter=Feature: containsAny DynamicResourceAllocation && Feature: isSubsetOf { Beta, DynamicResourceAllocation } && !Flaky && !Slow' | ||
| - '--test-args=--feature-gates="DynamicResourceAllocation=true" --service-feature-gates="DynamicResourceAllocation=true" --runtime-config=api/beta=true --container-runtime-endpoint=unix:///var/run/crio/crio.sock --container-runtime-process-name=/usr/local/bin/crio --container-runtime-pid-file= --kubelet-flags="--cgroup-driver=systemd --cgroups-per-qos=true --cgroup-root=/ --runtime-cgroups=/system.slice/crio.service --kubelet-cgroups=/system.slice/kubelet.service" --extra-log="{\"name\": \"crio.log\", \"journalctl\": [\"-u\", \"crio\"]}"' | ||
| - --image-config-file=/home/prow/go/src/k8s.io/test-infra/jobs/e2e_node/crio/latest/image-config-cgroupv2-serial.yaml | ||
| env: | ||
| - name: IGNITION_INJECT_GCE_SSH_PUBLIC_KEY_FILE | ||
| value: "1" | ||
| - name: GOPATH | ||
| value: /go | ||
| - name: KUBE_SSH_USER | ||
| value: core | ||
| resources: | ||
| limits: | ||
| cpu: 2 | ||
| memory: 9Gi | ||
| requests: | ||
| cpu: 2 | ||
| memory: 9Gi | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't have to create "kubetest2-canary". Just modify the existing "canary" job.
That conflicts with other, concurrent changes to canary, like my timeout changes. In practice, most of the time we are only going to try one experimental change at a time, so that should be okay.
Let me wrap up my experimental work by merging it into the main jobs...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once #34166 is merged, you can make whatever change you want for the canary jobs inside if sections, similar to how I did it in #34150.