Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KEP-3973]: update the DeploymentPodReplacementPolicy FG references to DeploymentReplicaSetTerminatingReplicas #50287

Open
wants to merge 1 commit into
base: dev-1.33
Choose a base branch
from
Open

[KEP-3973]: update the DeploymentPodReplacementPolicy FG references to DeploymentReplicaSetTerminatingReplicas #50287

wants to merge 1 commit into from

Conversation

atiratree
Copy link
Member

@atiratree atiratree commented Mar 27, 2025 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 27, 2025
@netlify Netlify
Copy link

netlify bot commented Mar 27, 2025

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit e4e928f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/67e5a9597cc88e0008126dff

@atiratree
Copy link
Member Author

PTAL @soltysh @tengqm @windsonsea @liggitt

@atiratree atiratree mentioned this pull request Mar 27, 2025
Merged
@netlify Netlify
Copy link

netlify bot commented Mar 27, 2025

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit e4e928f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67e5a959741bfd0008ea12ff
😎 Deploy Preview https://deploy-preview-50287--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tengqm
Copy link
Contributor

tengqm commented Mar 29, 2025

/approve
/hold
Explicit hold this for upstream change to happen.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 29, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2025
@atiratree
Copy link
Member Author

/hold cancel
kubernetes/kubernetes#131088 has merged

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katcosgrove katcosgrove Awaiting requested review from katcosgrove

@natalisucks natalisucks Awaiting requested review from natalisucks

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atiratree @tengqm @k8s-ci-robot