Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - MTV-2053: Update links in forklift-console-plugin #1470

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anarnold97
Copy link
Contributor

@anarnold97 anarnold97 commented Feb 11, 2025

📝 Links

References:

Add more JIRA, Docs, and other PR/Issue links

📝 Description

Update links in forklift-console-plugin from 2.7 docs to 2.8 docs

Please note it is marked as WIP. You cannot merge until 2.8 is ready and the 2.8 docs are ready so we can validate agains the final set of docs before being published

Add a brief description

🎥 Demo

Please add a video or an image of the behavior/changes

📝 CC://

@tag as needed

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.51%. Comparing base (13484d0) to head (391d855).
Report is 244 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1470      +/-   ##
==========================================
- Coverage   36.81%   36.51%   -0.31%     
==========================================
  Files         158      156       -2     
  Lines        2548     2528      -20     
  Branches      599      604       +5     
==========================================
- Hits          938      923      -15     
- Misses       1428     1600     +172     
+ Partials      182        5     -177     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mnecas mnecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avivtur
Copy link
Collaborator

avivtur commented Mar 16, 2025

@anarnold97 Hi :)
Is this PR still WIP? can we proceed with it? Please update the PR's description to have the Jira ticket URL.
Thank you!

@anarnold97
Copy link
Contributor Author

@anarnold97 Hi :) Is this PR still WIP? can we proceed with it? Please update the PR's description to have the Jira ticket URL. Thank you!

@avivtur - No, of course you cannot proceed, the changes are 2.8. please read PRs before you comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants