MTV-1988: Add knip #1498
Open
MTV-1988: Add knip #1498
+222
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joachim Schuler <[email protected]>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1498 +/- ##
==========================================
- Coverage 36.81% 36.31% -0.50%
==========================================
Files 158 157 -1
Lines 2548 2569 +21
Branches 599 613 +14
==========================================
- Hits 938 933 -5
- Misses 1428 1449 +21
- Partials 182 187 +5 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Joachim Schuler <[email protected]>
metalice
reviewed
Feb 25, 2025
| @@ -0,0 +1,29 @@ | |||
| { | |||
| "$schema": "https://json.schemastore.org/tsconfig", | |||
There was a problem hiding this comment.
I've never used $schema in my configs. Do we really need it?
Also, do we need all the other settings? please go over the list and see if we can omit uneeded settings.
There was a problem hiding this comment.
we can check the settings, maybe in a separate issue. I needed a root tsconfig to make knip happy so took all the common config items and extracted out
|
From the results here, it seems like knip needs its config file with entry points; as this is a plugin with no single point of entry, like index.js, main.js, or such, we should add a config file with entries to tell knip from where to scan. |
|
I updated the settings. It was previously not picking up all the dynamic module entries so I had to add them |
Signed-off-by: Joachim Schuler <[email protected]>
Signed-off-by: Joachim Schuler <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Links
https://issues.redhat.com/browse/MTV-1988
📝 Description
Adds the base knip config.
Followup PRs will start to address the reported issues.
🎥 Demo
📝 Followup PRs
Remove unused files
Remove unused export types