[MTV-1794] Update provider vCenter validation

[jpuzz0]

📝 Links

https://issues.redhat.com/browse/MTV-1794

📝 Description

Address feedback related to this comment: https://issues.redhat.com/browse/MTV-1794?focusedId=26727397&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-26727397

🎥 Demo

Screen.Recording.2025-03-12.at.1.29.19.PM.mov

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 13.33333% with 13 lines in your changes missing coverage. Please review.

Project coverage is 36.22%. Comparing base (13484d0) to head (d0d9e67).
Report is 381 commits behind head on main.

Files with missing lines	Patch %	Lines
.../validators/provider/vsphere/validateVCenterURL.ts	16.66%	3 Missing and 2 partials ⚠️
...ers/modals/EditProviderURL/VSphereEditURLModal.tsx	20.00%	4 Missing ⚠️
...ators/provider/vsphere/vsphereProviderValidator.ts	0.00%	3 Missing ⚠️
...ers/utils/validators/provider/providerValidator.ts	0.00%	1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1523      +/-   ##
==========================================
- Coverage   36.81%   36.22%   -0.59%     
==========================================
  Files         158      157       -1     
  Lines        2548     2595      +47     
  Branches      599      632      +33     
==========================================
+ Hits          938      940       +2     
- Misses       1428     1461      +33     
- Partials      182      194      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[avivtur]

/lgtm

[sgratch]

@jpuzz0 please see comment below
I suggest removing the urlMatchesCertFqdn ui validation and leave only the following validation:

f (isValidIpAddress) {
      return {
        type: 'warning',
        msg: 'The URL is not a fully qualified domain name (FQDN). If the certificate does not match the URL, the connection might fail.',
};

[sgratch]

@jpuzz0
Thanks for removing the error. Please check the following comments:

1. Still need to handle the edit URL for vcenter verification since currently when editing a URL of an existing vcenter insecure provider, the warning of "The URL is not a fully qualified domain name (FQDN)..." is initially displayed:

Screencast.from.2025-03-18.16-12-35.webm

2. Consider rephrasing the warning text to something like:
   "The URL is not a fully qualified domain name (FQDN). If the certificate is not skipped and does not match the URL, the connection might fail. "

@RichardHoch can you please advice?

[sgratch]

CC:// @RichardHoch @anarnold97

[jpuzz0]

@jpuzz0 Thanks for removing the error. Please check the following comments:

1. Still need to handle the edit URL for vcenter verification since currently when editing a URL of an existing vcenter insecure provider, the warning of "The URL is not a fully qualified domain name (FQDN)..." is initially displayed:

Screencast.from.2025-03-18.16-12-35.webm
2. Consider rephrasing the warning text to something like:
"The URL is not a fully qualified domain name (FQDN). If the certificate is not skipped and does not match the URL, the connection might fail. "

@RichardHoch can you please advice?

@sgratch I've updated the text to your suggestion and updated the edit validation.

[sgratch]

All issues mentioned above were addresses.
I see that something seems broken with the VSphereEditURLModal url field validation for the vcenter end point. The validation text message is not re-rendered as required and the initial value is also wrong (note that the text message flickers once opening the modal):

Before this fix:

Screencast.from.2025-03-19.12-07-59.webm

After this fix:

Screencast.from.2025-03-19.12-09-20.webm

[jpuzz0]

@sgratch The flickering is due to us now having to fetch the secret to make this validation check - since it depends on whether the connection is marked as secure or not. I will make the request happen on page entry versus modal open to prevent this.

Otherwise, I noticed there was an issue with how I was passing down the input value for URL, so the rest should be fixed here as well.

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud