Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTV-1974: Move common package into forklift #1524

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

avivtur
Copy link
Collaborator

@avivtur avivtur commented Mar 12, 2025

📝 Links

References: https://issues.redhat.com/browse/MTV-1974

📝 Description

Moving common package to the main package to have a flat hierarchy, no real use case for have a separated package

Note: currently only moving the common package as is into forklift-console-plugin/src/components/common
in next steps will refactor components and will remove unneeded components.
Once #1505 is merged we can remove the common package completely

@avivtur avivtur force-pushed the remove-common branch 3 times, most recently from c2b21e1 to 9c61834 Compare March 13, 2025 10:15
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.32%. Comparing base (13484d0) to head (08ae335).
Report is 354 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1524      +/-   ##
==========================================
- Coverage   36.81%   36.32%   -0.49%     
==========================================
  Files         158      159       +1     
  Lines        2548     2593      +45     
  Branches      599      622      +23     
==========================================
+ Hits          938      942       +4     
- Misses       1428     1462      +34     
- Partials      182      189       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants