-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MTV-2247] Initial new create plan wizard setup #1525
Conversation
f0cd197
to
a27e320
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1525 +/- ##
==========================================
- Coverage 36.81% 36.22% -0.59%
==========================================
Files 158 157 -1
Lines 2548 2595 +47
Branches 599 630 +31
==========================================
+ Hits 938 940 +2
- Misses 1428 1461 +33
- Partials 182 194 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hey @jpuzz0 no need to nest the files under modules , we will omit the this folder. |
packages/forklift-console-plugin/src/modules/Plans/views/create/CreatePlanWizard.tsx
Outdated
Show resolved
Hide resolved
...forklift-console-plugin/src/modules/Plans/views/create/components/CreatePlanWizardFooter.tsx
Outdated
Show resolved
Hide resolved
...forklift-console-plugin/src/modules/Plans/views/create/components/CreatePlanWizardFooter.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jpuzz0 great work!
I left some comments/ nit suggestions
packages/forklift-console-plugin/src/modules/Plans/views/create/CreatePlanWizard.tsx
Outdated
Show resolved
Hide resolved
packages/forklift-console-plugin/src/modules/Plans/views/create/CreatePlanWizard.tsx
Outdated
Show resolved
Hide resolved
packages/forklift-console-plugin/src/modules/Plans/views/create/PlanCreatePageV2.tsx
Outdated
Show resolved
Hide resolved
packages/forklift-console-plugin/src/modules/Plans/views/create/PlanCreatePageV2.tsx
Outdated
Show resolved
Hide resolved
packages/forklift-console-plugin/src/modules/Plans/views/create/PlanCreatePageV2.tsx
Outdated
Show resolved
Hide resolved
packages/forklift-console-plugin/src/modules/Plans/views/create/PlanCreatePageV2.tsx
Outdated
Show resolved
Hide resolved
...forklift-console-plugin/src/modules/Plans/views/create/components/CreatePlanWizardFooter.tsx
Outdated
Show resolved
Hide resolved
...ages/forklift-console-plugin/src/modules/Plans/views/create/steps/GeneralInformationForm.tsx
Outdated
Show resolved
Hide resolved
357f963
to
c1c1c83
Compare
packages/forklift-console-plugin/src/plans/create/CreatePlanWizard.tsx
Outdated
Show resolved
Hide resolved
packages/forklift-console-plugin/src/plans/create/CreatePlanWizardFooter.tsx
Outdated
Show resolved
Hide resolved
packages/forklift-console-plugin/src/plans/create/CreatePlanWizard.tsx
Outdated
Show resolved
Hide resolved
packages/forklift-console-plugin/src/components/FormErrorHelperText.tsx
Outdated
Show resolved
Hide resolved
packages/forklift-console-plugin/src/plans/create/steps/GeneralInformationForm.tsx
Outdated
Show resolved
Hide resolved
packages/forklift-console-plugin/src/plans/create/steps/GeneralInformationForm.tsx
Outdated
Show resolved
Hide resolved
packages/forklift-console-plugin/src/plans/create/steps/GeneralInformationForm.tsx
Show resolved
Hide resolved
1791333
to
7bd5db1
Compare
packages/forklift-console-plugin/src/plans/create/CreatePlanWizardFooter.tsx
Outdated
Show resolved
Hide resolved
7bd5db1
to
7c15c85
Compare
Signed-off-by: Jeff Puzzo <[email protected]>
7c15c85
to
a55f2c9
Compare
|
📝 Links
https://issues.redhat.com/browse/MTV-2247
📝 Description
Initial setup of the newer wizard which is mainly getting the framework of using react-hook-form and validation established between steps and demonstrating a single field's data is stored and submittable from the Review and create (last) step.
Accessible for testing via a new URL,
http://localhost:9000/mtv/create/plan
, which will have to be entered manually, as the actions to create migration plans throughout the plugin still point to the current wizard.🎥 Demo
Screen.Recording.2025-03-17.at.3.21.49.PM.mov
📝 CC://