Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MTV-2247] Initial new create plan wizard setup #1525

Merged
merged 2 commits into from
Mar 24, 2025

Conversation

jpuzz0
Copy link
Contributor

@jpuzz0 jpuzz0 commented Mar 17, 2025

📝 Links

https://issues.redhat.com/browse/MTV-2247

📝 Description

Initial setup of the newer wizard which is mainly getting the framework of using react-hook-form and validation established between steps and demonstrating a single field's data is stored and submittable from the Review and create (last) step.

Accessible for testing via a new URL, http://localhost:9000/mtv/create/plan, which will have to be entered manually, as the actions to create migration plans throughout the plugin still point to the current wizard.

🎥 Demo

Screen.Recording.2025-03-17.at.3.21.49.PM.mov

📝 CC://

@mmenestr

@jpuzz0 jpuzz0 force-pushed the MTV-2247-init-wizard-setup branch 2 times, most recently from f0cd197 to a27e320 Compare March 17, 2025 19:18
@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.22%. Comparing base (13484d0) to head (e397761).
Report is 395 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1525      +/-   ##
==========================================
- Coverage   36.81%   36.22%   -0.59%     
==========================================
  Files         158      157       -1     
  Lines        2548     2595      +47     
  Branches      599      630      +31     
==========================================
+ Hits          938      940       +2     
- Misses       1428     1461      +33     
- Partials      182      194      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@metalice
Copy link
Collaborator

Hey @jpuzz0 no need to nest the files under modules , we will omit the this folder.
src/Plans

Copy link
Collaborator

@avivtur avivtur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpuzz0 great work!
I left some comments/ nit suggestions

@jpuzz0 jpuzz0 force-pushed the MTV-2247-init-wizard-setup branch from 357f963 to c1c1c83 Compare March 18, 2025 19:51
@jpuzz0 jpuzz0 force-pushed the MTV-2247-init-wizard-setup branch 2 times, most recently from 1791333 to 7bd5db1 Compare March 19, 2025 17:49
@jpuzz0 jpuzz0 added the enhancement Categorizes issue or PR as related to a new feature. label Mar 19, 2025
@jpuzz0 jpuzz0 requested a review from metalice March 19, 2025 17:51
@jpuzz0 jpuzz0 force-pushed the MTV-2247-init-wizard-setup branch from 7bd5db1 to 7c15c85 Compare March 19, 2025 20:55
@jpuzz0 jpuzz0 requested a review from metalice March 19, 2025 20:56
@jpuzz0 jpuzz0 force-pushed the MTV-2247-init-wizard-setup branch from 7c15c85 to a55f2c9 Compare March 20, 2025 14:42
@metalice metalice merged commit 9af1359 into kubev2v:main Mar 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants