MTV-2197: Plan name error text wrong for special characters #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avivtur
force-pushed
the
unique-chars-plan-name
branch
from
3271b23 to
8a49d02
Compare
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1527 +/- ##
==========================================
- Coverage 36.81% 36.14% -0.67%
==========================================
Files 158 157 -1
Lines 2548 2606 +58
Branches 599 633 +34
==========================================
+ Hits 938 942 +4
- Misses 1428 1470 +42
- Partials 182 194 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
metalice
reviewed
Mar 19, 2025
| @@ -23,16 +23,27 @@ export const PlanNameTextField: React.FC<PlanNameTextFieldProps> = ({ | |||
| const { t } = useForkliftTranslation(); | |||
| const [isUpdated, setIsUpdated] = React.useState(false); | |||
|
|
|||
| const getInvalidHelperText = () => { | |||
There was a problem hiding this comment.
To avoid sending 3 params: value, validated and, t func
avivtur
force-pushed
the
unique-chars-plan-name
branch
2 times, most recently
from
6ffa3f4 to
75cc778
Compare
Signed-off-by: Aviv Turgeman <[email protected]>
avivtur
force-pushed
the
unique-chars-plan-name
branch
from
75cc778 to
71cb12d
Compare
|
metalice
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Links
📝 Description
we validate different conditions but we have same validation error message for all types of error.
separated messages according to the error.
🎥 Demo
fix-plan-name-validation.mp4
📝 CC://