Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTV-2265: Present template naming fields only for vsphere provider #1531

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

avivtur
Copy link
Collaborator

@avivtur avivtur commented Mar 19, 2025

📝 Links

References: https://redhat-internal.slack.com/archives/C07HDAK66QG/p1742384437713739?thread_ts=1742378635.575279&cid=C07HDAK66QG

📝 Description

Changing to template settings to be shown only for vsphere provider plans

🎥 Demo

Please add a video or an image of the behavior/changes

📝 CC://

@tag as needed

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.13%. Comparing base (13484d0) to head (d74e928).
Report is 375 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1531      +/-   ##
==========================================
- Coverage   36.81%   36.13%   -0.68%     
==========================================
  Files         158      157       -1     
  Lines        2548     2604      +56     
  Branches      599      620      +21     
==========================================
+ Hits          938      941       +3     
- Misses       1428     1477      +49     
- Partials      182      186       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avivtur avivtur changed the title Present template naming fields only for vsphere provider MTV-2265: Present template naming fields only for vsphere provider Mar 19, 2025
@avivtur avivtur merged commit d8a29b0 into kubev2v:main Mar 19, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants