Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTV-2266: Avoid displaying the "Host cluster" label for non ocp providers #1532

Merged

Conversation

sgratch
Copy link
Collaborator

@sgratch sgratch commented Mar 19, 2025

Reference: https://issues.redhat.com/browse/MTV-2266

📝 Description

Display the "host cluster" label only for ocp providers and not for other providers types.

🎥 Demo

Before

image

After

Screenshot from 2025-03-19 16-03-41

…ders

Reference: https://issues.redhat.com/browse/MTV-2266

Display the "host cluster" label only for ocp providers with an empty
url field and not for other providers types.

Signed-off-by: Sharon Gratch <[email protected]>
@sgratch sgratch added the bug Categorizes issue or PR as related to a bug. label Mar 19, 2025
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.14%. Comparing base (13484d0) to head (a310b0f).
Report is 379 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1532      +/-   ##
==========================================
- Coverage   36.81%   36.14%   -0.67%     
==========================================
  Files         158      157       -1     
  Lines        2548     2606      +58     
  Branches      599      632      +33     
==========================================
+ Hits          938      942       +4     
- Misses       1428     1654     +226     
+ Partials      182       10     -172     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avivtur avivtur merged commit e93a32e into kubev2v:main Mar 19, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants