[MTV-1905] Update canceled VM status icon #1533
Merged
+78
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1533 +/- ##
==========================================
- Coverage 36.81% 36.14% -0.67%
==========================================
Files 158 157 -1
Lines 2548 2606 +58
Branches 599 631 +32
==========================================
+ Hits 938 942 +4
- Misses 1428 1470 +42
- Partials 182 194 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sgratch
reviewed
Mar 19, 2025
packages/forklift-console-plugin/src/modules/Plans/views/list/components/PlanStatusVmCount.tsx
Outdated
Show resolved
Hide resolved
packages/forklift-console-plugin/src/modules/Plans/views/list/components/PlanStatusCell.tsx
Show resolved
Hide resolved
Signed-off-by: Jeff Puzzo <[email protected]>
jpuzz0
force-pushed
the
MTV-1905-update-canceled-vms-icon
branch
from
2e72e16 to
e3ede68
Compare
|
sgratch
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Links
https://issues.redhat.com/browse/MTV-1905
📝 Description
Updated
Canceledicon for PlanStatusCell, and added at least temporary tooltips as demonstrated in the video below to help users distinguish between what has canceled, succeeded and failed when they have multiple VM counts next to a single status label. Fixed spacing while I was in there as well.🎥 Demo
Screen.Recording.2025-03-19.at.12.39.07.PM.mov
📝 CC://