MTV-2236 | Use unshare seccomp profile #1445
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: Right now the migration using the quay.io/kubev2v/forklift-virt-v2v:latest fails due to the passt missing permissions. The root cause of this issue is in the passt using the `unshare(2)` syscall. The passt was added to the virt-v2v libguestfs which introduced this issue. The CRI-O is missing the `unshare(2)` from the seccomp settings. We need to specify to use the seccomp which allows the `unshare(2)` syscall and add it to the MTVs SecurityContextConstraints. Fix: Add the unshare seccomp profile to the guest conversion pod. Ref: https://issues.redhat.com/browse/MTV-2236 Signed-off-by: Martin Necas <[email protected]>
mnecas
changed the title
|
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1445 +/- ##
==========================================
- Coverage 15.45% 15.10% -0.36%
==========================================
Files 112 113 +1
Lines 23377 24310 +933
==========================================
+ Hits 3613 3672 +59
- Misses 19479 20351 +872
- Partials 285 287 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Right now the migration using the quay.io/kubev2v/forklift-virt-v2v:latest fails due to the passt missing permissions. The root cause of this issue is in the passt using the
unshare(2)syscall. The passt was added to the virt-v2v libguestfs which introduced this issue. The CRI-O is missing theunshare(2)from the seccomp settings. We need to specify to use the seccomp which allows theunshare(2)syscall and add it to the MTVs SecurityContextConstraints.Fix: Add the unshare seccomp profile to the guest conversion pod.
Ref: https://issues.redhat.com/browse/MTV-2236