Use templates for deploy-on-kind and use envconfig for configuration #186
+356
−516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nirarg
commented
Mar 13, 2025
nirarg
commented
- Add script to convert template to manifest file, include changing the params to right values
- Use the autogenerated manifst for kind deployment
- Rewrite deploy and delete operation to use the template files (both Openshift and Kind)
- Change configuration file to be created using envconfig library
- Add --platform=linux/amd64 to support running on macOS
- Add GREP environment variable to allow changing executer on macOS
|
Can one of the admins verify this patch? |
* Add script to convert template to manifest file, include changing the params to right values * Use the autogenerated manifst for kind deployment * Rewrite deploy and delete operation to use the template files (both Openshift and Kind) * Change configuration file to be created using envconfig library * Add --platform=linux/amd64 to support running on macOS * Add GREP environment variable to allow changing executer on macOS Signed-off-by: Nir Argaman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.