Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Addon] Chartmuseum AWS S3 auth without keys and custom ingress class #744

Merged
merged 4 commits into from
Jan 8, 2024

Conversation

oanasc
Copy link
Contributor

@oanasc oanasc commented Dec 8, 2023

Description of your changes

Fixes #742 and #743

How has this code been tested?

I enabled the addon on a EKS cluster and ensured the charts are able to publish and access to S3 is possible using the credential chain with no aws key id and secret provided.
And for the ingress change I provided our ingress class and verified the ingress is working.

The only thing I don't know is if there should be any corresponding UX change for the addon parameters. Please point me upon review if there is something that needs updating

Checklist

I have:

  • Title of the PR starts with type (e.g. [Addon] , [example] or [Doc]).
  • Updated/Added any relevant documentation and examples.
  • New addon should be put in experimental.
  • Update addon should modify the version in metadata.yaml to generate a new version.

Verified Addon promotion rules

If this pr wants to promote an experimental addon to verified, you must check whether meet these conditions too:

  • This addon must be tested by addon's e2e-test to guarantee this addon can be enabled successfully.
  • This addon must have some basic but necessary information.
    • An accessible icon url and source url defined in addon's metadata.yaml.
    • A detail introduction include a basic example about how to use and what's the benefit of this addon in README.md.
    • Also provide an introduction in KubeVela documentation.
    • It's more likely to be accepted if useful examples provided in example dir.

@oanasc
Copy link
Contributor Author

oanasc commented Dec 21, 2023

@charlie0129, @wangyikewxgm may I get a review on this please

wonderflow
wonderflow previously approved these changes Dec 25, 2023
Copy link
Collaborator

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides the nit

Signed-off-by: Oana Schipor <[email protected]>
@wonderflow wonderflow merged commit f4ddd9d into kubevela:master Jan 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chartmuseum s3 aws auth using credential chain
3 participants