[Addon] Chartmuseum AWS S3 auth without keys and custom ingress class #744
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #742 and #743
How has this code been tested?
I enabled the addon on a EKS cluster and ensured the charts are able to publish and access to S3 is possible using the credential chain with no aws key id and secret provided.
And for the ingress change I provided our ingress class and verified the ingress is working.
The only thing I don't know is if there should be any corresponding UX change for the addon parameters. Please point me upon review if there is something that needs updating
Checklist
I have:
[Addon]
,[example]
or[Doc]
).version
inmetadata.yaml
to generate a new version.Verified Addon promotion rules
If this pr wants to promote an experimental addon to verified, you must check whether meet these conditions too:
metadata.yaml
.README.md
.