Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: replace deprecated command with environment file #895

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jongwooo
Copy link

Description of your changes

Closes #894

Update .github/workflows/release.yml to use environment file instead of deprecated set-output command.
For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I found the workflow file that use set-output command through the following command:

$ find . -name '*.yml' -o -name '*.yaml' | xargs egrep '\bset-output\b'

AS-IS

echo ::set-output name=VERSION::${VERSION}

TO-BE

echo "VERSION=${VERSION}" >> $GITHUB_OUTPUT

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

None

Copy link

codecov bot commented Dec 16, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (2ab672c) 59.01% compared to head (82c3583) 32.59%.
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/server/interfaces/api/application.go 0.00% 2 Missing ⚠️
pkg/server/interfaces/api/plugin.go 0.00% 1 Missing ⚠️
pkg/server/interfaces/api/repository.go 0.00% 1 Missing ⚠️
pkg/server/interfaces/api/target.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #895       +/-   ##
===========================================
- Coverage   59.01%   32.59%   -26.43%     
===========================================
  Files         116       91       -25     
  Lines       19846    17940     -1906     
===========================================
- Hits        11713     5848     -5865     
- Misses       6696    11212     +4516     
+ Partials     1437      880      -557     
Flag Coverage Δ
apiserver-unittests 32.59% <0.00%> (-0.03%) ⬇️
server-e2e-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated set-output command with environment file
1 participant