Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The origin-kube-rbac-proxy image is not compatible with the s390x #1914

Conversation

ashokpariya0
Copy link
Contributor

@ashokpariya0 ashokpariya0 commented Oct 7, 2024

architecture. This change deploys an image that is compatible with amd64, arm and s390x architecture.

What this PR does / why we need it:
The origin-kube-rbac-proxy image is not compatible with the s390x
architecture. This change deploys an image that is compatible with
amd64, arm and s390x.

Special notes for your reviewer:

Release note:

This change addresses the compatibility issues with the origin-kube-rbac-proxy image on the s390x architecture. The updated deployment now uses an image that supports the amd64, arm and s390x architectures.
This enhancement ensures broader support and improved functionality across diverse environments.

architecture. This change deploys an image that is compatible with
amd64, arm and s390x architecture.

Signed-off-by: Ashok Pariya <[email protected]>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 7, 2024
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign phoracek for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot
Copy link
Collaborator

Hi @ashokpariya0. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot added size/XS release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 7, 2024
@oshoval
Copy link
Collaborator

oshoval commented Oct 7, 2024

/hold

thanks but this cant be done this way
we should do it correctly
image cant just be changed

@oshoval oshoval closed this Oct 7, 2024
@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 7, 2024
@oshoval oshoval reopened this Oct 7, 2024
@oshoval
Copy link
Collaborator

oshoval commented Oct 7, 2024

please open an issue instead and we will see what can be done and if we should support it upstream

Copy link

sonarcloud bot commented Oct 7, 2024

@ashokpariya0
Copy link
Contributor Author

please open an issue instead and we will see what can be done and if we should support it upstream
Thanks, done that. Issue link: #1916

@oshoval
Copy link
Collaborator

oshoval commented Oct 8, 2024

thanks
lets continue there

/close

@oshoval oshoval closed this Oct 8, 2024
@oshoval
Copy link
Collaborator

oshoval commented Oct 8, 2024

maybe meanwhile in case you do cluster-sync you can use this env var locally ?

--kube-rbac-proxy-image=${KUBE_RBAC_PROXY_IMAGE} \

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants