Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Make PSA on by default. (#1382)" #1388

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

brianmcarey
Copy link
Member

@brianmcarey brianmcarey commented Mar 4, 2025

What this PR does / why we need it:

This reverts commit d6b1cf7.

Some lanes hit issues when PSA is enabled by default and this blocking us from delivering kubevirtci updates into kubevirt (kubevirt/kubevirt#14055)

Revert for now until the issue with the sig-performance lanes[1] is resolved.

[1] kubevirt/kubevirt#14090

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/cc @xpivarc @dhiller

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:


Sorry, something went wrong.

This reverts commit d6b1cf7.

Some lanes hit issues when PSA is enabled by default and this blocking
us from delivering kubevirtci updates into kubevirt.

Revert for now until the issue with the sig-performance lanes[1] is
resolved.

[1] kubevirt/kubevirt#14090

Signed-off-by: Brian Carey <[email protected]>
@kubevirt-bot kubevirt-bot requested a review from dhiller March 4, 2025 09:56
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Mar 4, 2025
@kubevirt-bot kubevirt-bot requested a review from xpivarc March 4, 2025 09:56
@dosubot dosubot bot added the kind/bug label Mar 4, 2025
@kubevirt-bot
Copy link
Contributor

@brianmcarey: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
check-provision-k8s-1.31-s390x f896ea6 link false /test check-provision-k8s-1.31-s390x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2025
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2025
@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-bot kubevirt-bot merged commit 2627fc1 into kubevirt:main Mar 4, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug lgtm Indicates that a PR is ready to be merged. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants