k8s-1.33: Update url to check previous k8s version #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
the
dco-signoff: yes
dhiller
reviewed
Mar 13, 2025
| @@ -13,7 +13,7 @@ function getKubernetesClosestStableVersion() { | |||
| kubernetes_minor_version=$(echo $kubernetes_version | cut -d. -f2) | |||
| packages_major_version=$(echo $kubernetes_version | cut -d. -f1) | |||
| packages_minor_version=$((kubernetes_minor_version-1)) | |||
| packages_version="$(curl --fail -L "https://storage.googleapis.com/kubernetes-release/release/stable-${packages_major_version}.${packages_minor_version}.txt" | sed 's/^v//')" | |||
| packages_version="$(curl --fail -L "https://raw.githubusercontent.com/kubevirt/kubevirtci/refs/heads/main/cluster-provision/k8s/1.${packages_minor_version}/version")" | |||
There was a problem hiding this comment.
I am not sure whether we should use ourselves as a source of truth around k8s release versions - is there no other way to determine the latest stable k8s version from any kubernetes release resource?
There was a problem hiding this comment.
I thought this would be a good solution as that is the latest known good version that we are testing with for the previous provider.
I wouldn't consider it a source of truth - in this case we just need some recent version to install the rpms - the binaries get replaced later anyway.
There was a problem hiding this comment.
I think I have found a better option.
The old URL used to check the previous kubernetes version no longer exists for versions greater than v1.31 - this is causing the provisioning of the k8s-1.33 provider to fail[1] Update to get the version from the kubevirtci repo itself. [1] https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_project-infra/4010/rehearsal-check-provision-k8s-1.33/1899779863519170560#1:build-log.txt%3A166 Signed-off-by: Brian Carey <[email protected]>
brianmcarey
force-pushed
the
fix-previous-version-check
branch
from
599ae08 to
8f6490e
Compare
dhiller
approved these changes
Mar 13, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhiller The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
kubevirt-bot
added a commit
to kubevirt-bot/kubevirt
that referenced
this pull request
Mar 15, 2025
[fe4dac8 Run go run ./robots/cmd/kubevirtci-bumper -ensure-last-three-minor-of v1 --k8s-provider-dir /home/prow/go/src/github.com/kubevirt/project-infra/../kubevirtci/cluster-provision/k8s](kubevirt/kubevirtci#1394) [cb8dee6 k8s-1.33: Update url to check previous k8s version](kubevirt/kubevirtci#1396) [60517a0 k8s-1.33: Add new provider for Kubernetes version 1.33](kubevirt/kubevirtci#1392) ```release-note NONE ``` Signed-off-by: kubevirt-bot <[email protected]>
kubevirt-bot
added a commit
to kubevirt-bot/kubevirt
that referenced
this pull request
Mar 16, 2025
[fe4dac8 Run go run ./robots/cmd/kubevirtci-bumper -ensure-last-three-minor-of v1 --k8s-provider-dir /home/prow/go/src/github.com/kubevirt/project-infra/../kubevirtci/cluster-provision/k8s](kubevirt/kubevirtci#1394) [cb8dee6 k8s-1.33: Update url to check previous k8s version](kubevirt/kubevirtci#1396) [60517a0 k8s-1.33: Add new provider for Kubernetes version 1.33](kubevirt/kubevirtci#1392) ```release-note NONE ``` Signed-off-by: kubevirt-bot <[email protected]>
kubevirt-bot
added a commit
to kubevirt-bot/kubevirt
that referenced
this pull request
Mar 16, 2025
[fe4dac8 Run go run ./robots/cmd/kubevirtci-bumper -ensure-last-three-minor-of v1 --k8s-provider-dir /home/prow/go/src/github.com/kubevirt/project-infra/../kubevirtci/cluster-provision/k8s](kubevirt/kubevirtci#1394) [cb8dee6 k8s-1.33: Update url to check previous k8s version](kubevirt/kubevirtci#1396) [60517a0 k8s-1.33: Add new provider for Kubernetes version 1.33](kubevirt/kubevirtci#1392) ```release-note NONE ``` Signed-off-by: kubevirt-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The old URL used to check the previous kubernetes version no longer exists for versions greater than v1.31 - this is causing the provisioning of the k8s-1.33 provider to fail[1]
Update to get the version from the kubevirtci repo itself.
[1] https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_project-infra/4010/rehearsal-check-provision-k8s-1.33/1899779863519170560#1:build-log.txt%3A166
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
/cc @dhiller
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: