Apply irrelevant changes caused by touch #140
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wata727
commented
Jul 20, 2023
| @@ -329,6 +329,10 @@ def _update_row(attribute_names, attempted_action = 'update') | |||
| self.transaction_from = after_instance.transaction_from | |||
| self.transaction_to = after_instance.transaction_to | |||
|
|
|||
| if attempted_action == 'touch' | |||
| @_touch_attr_names += Set.new(['valid_from', 'valid_to', 'transaction_from', 'transaction_to']) | |||
There was a problem hiding this comment.
Append to an instance variable used by ActiveRecord::AttributeMethods::Dirty#_touch_row.
https://github.com/rails/rails/blob/v7.0.6/activerecord/lib/active_record/attribute_methods/dirty.rb#L187
This is probably not a good approach, but it's the only way to write out to the saved_changes at once with minimal changes.
wata727
commented
Jul 20, 2023
| @@ -27,10 +27,13 @@ | |||
| it { | |||
| is_expected.to have_attributes( | |||
| bitemporal_id: subject.id, | |||
| # changes: be_empty, | |||
There was a problem hiding this comment.
Perhaps the expected is be_empty, but unfortunately that is not the case at this time. This will be fixed in another PR.
wata727
commented
Jul 20, 2023
| @@ -1052,6 +1072,8 @@ class EmployeeWithUniquness < Employee | |||
| it { expect { subject }.to change { Employee.ignore_valid_datetime.within_deleted.count }.by(1) } | |||
| it { expect { subject }.to change(employee, :swapped_id).from(@swapped_id_before_destroy).to(kind_of(Integer)) } | |||
| it { expect { subject }.to change(employee, :swapped_id_previously_was).from(kind_of(Integer)).to(@swapped_id_before_destroy) } | |||
| xit { expect { subject }.to change(employee, :changes).to(be_empty) } | |||
There was a problem hiding this comment.
Perhaps the expected is be_empty, but unfortunately that is not the case at this time. This will be fixed in another PR.
wata727
requested review from
osyo-manga,
krororo and
Dooor
and removed request for
yono and
lighty
wata727
force-pushed
the
touch_without_changes
branch
from
204ac82
to
7d96d90
Compare
|
This PR is frozen because #148 may fix this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing some research, I noticed that models that include
ActiveRecord::Bitemporalhave unintended changes after being touched:Perhaps adding changes unintentionally is not the expected behavior.
This PR changes the
changescaused bytouchto be movedsaved_changes:As a side note, I noticed that unlike the non-bitemporal model, there was an issue where the dirty state before
touchwas unintentionally saved, but that's an issue that should be addressed in another PR.