Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine existing defaults configuration into one mode switch #12413

Open
slonka opened this issue Jan 2, 2025 · 4 comments · May be fixed by #12914
Open

Combine existing defaults configuration into one mode switch #12413

slonka opened this issue Jan 2, 2025 · 4 comments · May be fixed by #12914
Labels
kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it
Milestone
2.11.x

Comments

@slonka
Copy link
Contributor

slonka commented Jan 2, 2025

Description

Right now we have 4 switches (skipMeshCreation, skipTenantResources, createMeshRoutingResources, skipHostnameGenerators).

Following the MADR we decided to combine 4 switches to skip different resources into one mode option.

Suggested mode value:

I suggest we have the following values for mode:

  • None (prod/IaC use case)
  • All - default - (demo use case)

Because for serious use cases (prod, IaC) you want to track things manually in git and for demo you want to skip repeating the same things.
@slonka slonka added triage/pending This issue will be looked at on the next triage meeting kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Jan 2, 2025
@slonka slonka added this to the 2.10.x milestone Feb 17, 2025
@lahabana
Copy link
Contributor

For MinK this would be a parameter of the VCP? Or MinK would be none going forward

@lahabana lahabana modified the milestones: 2.10.x, 2.11.x Feb 17, 2025
@slonka slonka self-assigned this Feb 24, 2025
@slonka
Copy link
Contributor Author

slonka commented Feb 24, 2025 •
edited
Loading

Most likely it will be none going forward.

During a meeting we decided to go with a parameter.

@slonka slonka linked a pull request Feb 24, 2025 that will close this issue
Draft
@slonka
Copy link
Contributor Author

slonka commented Feb 26, 2025

Chagnes after today's meetings - https://docs.google.com/document/d/1tIfshA7-RFAgpWvptZ2iCYE6KUEMW-VHY-O2NRXo5r0/edit?tab=t.0#bookmark=id.81n9f1qhnhnh

@slonka
Copy link
Contributor Author

slonka commented Feb 27, 2025

Instead of this we decided to extend the /tenants endpoints.

@slonka slonka removed their assignment Feb 27, 2025
@slonka slonka mentioned this issue Feb 28, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
2.11.x
Development

Successfully merging a pull request may close this issue.

feat(config): combine default switches into mode slonka/kuma
2 participants
@lahabana @slonka