Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): combine default switches into mode #12914

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Feb 24, 2025

combine SkipMeshCreation SkipTenantResources and SkipHostnameGenerators into Mode

Motivation

Implementation information

Supporting documentation

Closes #12413

Copy link
Contributor

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

  • Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
  • PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
  • IPv6 is taken into account (.e.g: no string concatenation of host port)
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

// If true, it skips creating the default Mesh
// Deprecated: use mode instead.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. There is a way to add deprecation warnings in the logs which we should probably leverage here.
  2. be mindful of mink and CD and more generally backward compat
  3. in k8s should we auto default to none and have the default stuff be part of the helm chart?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. In config files it looks the same (word, "Deprecated" followed by ":"):

// Name of Service Account that is used to run the Control Plane
// Deprecated: Use AllowedUsers instead.
ServiceAccountName string `json:"serviceAccountName,omitempty" envconfig:"kuma_runtime_kubernetes_service_account_name"`

There is also a warning in Validate() function:

if c.ServiceAccountName != defaultServiceAccountName {
logger.Info("[WARNING]: using deprecated configuration option - .ServiceAccountName, please use AllowedUsers.")
}

So I assume it's about adding it in Validate() function.


will respond to rest of the points in a later comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combine existing defaults configuration into one mode switch
2 participants