-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(xds): add internal address config onto HttpConnectionManager #12986
feat(xds): add internal address config onto HttpConnectionManager #12986
Conversation
Signed-off-by: Jay Chen <[email protected]>
Signed-off-by: Jay Chen <[email protected]>
Signed-off-by: Jay Chen <[email protected]>
Signed-off-by: Jay Chen <[email protected]>
Signed-off-by: Jay Chen <[email protected]>
Reviewer Checklist🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
|
Signed-off-by: Jay Chen <[email protected]>
7ad0bf0
to
5900c2f
Compare
Signed-off-by: Jay Chen <[email protected]>
Signed-off-by: Jay Chen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add more test cases? I would like to see Gateway/ZoneEgress/ZoneIngress configuration change either by outbound_proxy
generator, Mesh*Route. Also, what about admin_proxy_generator
, prometheus_endpoint_generator
?
Signed-off-by: Jay Chen <[email protected]>
Signed-off-by: Jay Chen <[email protected]>
This makes me think if we should always set this config, I'm trying to do so in the updated commits. This introduces a lot of changes touching a wide range of files in which I only asserted the internal addresses are passed in via the Mesh*Route plugins. I'm leaving the value as blank/default in tests of other plugins since the feature is already tested from the all the levels:
|
Signed-off-by: Jay Chen <[email protected]>
Signed-off-by: Jay Chen <[email protected]>
We are using Envoy |
Signed-off-by: Jay Chen <[email protected]>
Signed-off-by: Jay Chen <[email protected]>
Signed-off-by: Jay Chen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation
add internal address config onto HttpConnectionManager, more details are available in issue #12190
Implementation information
introducing a new configuration item
ipam.knownInternalCIDRs
on zonal CP to allow users specify their known internal address pool and we assign these values when generating Envoy config for HttpConnectionManagerSupporting documentation
fixes #12190