Skip to content

Commit

Permalink
Address PR comments
Browse files Browse the repository at this point in the history
Signed-off-by: Zander Mackie <[email protected]>
  • Loading branch information
zmackie committed Mar 30, 2020
1 parent 05834ec commit d049260
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 5 deletions.
1 change: 0 additions & 1 deletion acceptance/acceptance_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1704,7 +1704,6 @@ func assertMockAppRunsWithOutput(t *testing.T, repoName string, expectedOutputs
assertMockAppResponseContains(t, launchPort, 10*time.Second, expectedOutputs...)
}

// TODO this can probably be abstracted along with `assertMockAppRunsWithOutput` to a more generic function
func assertMockAppLogs(t *testing.T, repoName string, expectedOutputs ...string) {
t.Helper()
containerName := "test-" + h.RandString(10)
Expand Down
4 changes: 0 additions & 4 deletions client.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import (
"context"
"os"
"path/filepath"
"time"

"github.com/buildpacks/imgutil"
dockerClient "github.com/docker/docker/client"
Expand Down Expand Up @@ -47,8 +46,6 @@ type Client struct {

type ClientOption func(c *Client)

var ClientTimeout = 1 * time.Minute

// WithLogger supply your own logger.
func WithLogger(l logging.Logger) ClientOption {
return func(c *Client) {
Expand Down Expand Up @@ -109,7 +106,6 @@ func NewClient(opts ...ClientOption) (*Client, error) {
client.docker, err = dockerClient.NewClientWithOpts(
dockerClient.FromEnv,
dockerClient.WithVersion("1.38"),
dockerClient.WithTimeout(ClientTimeout),
)
if err != nil {
return nil, err
Expand Down

0 comments on commit d049260

Please sign in to comment.