Logging/fixes tweaks #548
Open
Logging/fixes tweaks #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #543
Summary
Some basic tweaks to logging.
\n, instead of replacing it with,.DEBUG, and replaced with a far shorter version atWARNINGLocal Tests
Logs work as expected, the
16000character message limit does indeed stop messages from causing a crash when logging to the syslog. On my system the max unix socket message size is212992, and could accommodate significantly larger messages than16000. This number can be adjusted, if desired.End-to-End Tests
Not relevant to E2E