Skip to content
This repository has been archived by the owner on Nov 22, 2024. It is now read-only.

Prevent adding duplicate parts to message #19 #20

Closed
wants to merge 2 commits into from
Closed

Prevent adding duplicate parts to message #19 #20

wants to merge 2 commits into from

Conversation

jamesshaw1987
Copy link

Fixes #19 by using in_array, which performs a loose comparison by default.

Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such kind of fix requires a test case to verify the issue and fix are valid

@Ocramius Ocramius added Awaiting Author Updates Bug Something isn't working labels Sep 20, 2021
@Ocramius
Copy link
Member

Being a bugfix, this should probably target 2.9.x

@jamesshaw1987
Copy link
Author

Ok, I'll sort a test and commit to 2.9.*.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Awaiting Author Updates Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a duplicate part to a message should not be permitted
2 participants