StreamMode in Join [sdk] #3584
Draft
StreamMode in Join [sdk] #3584
+1,068
−914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
hinthornw
force-pushed
the
wfh/join_stream_mode
branch
5 times, most recently
from
427d539 to
f1941b9
Compare
hinthornw
force-pushed
the
wfh/join_stream_mode
branch
from
f1941b9 to
f679348
Compare
nfcampos
reviewed
Feb 25, 2025
libs/sdk-py/langgraph_sdk/client.py
Outdated
| run_id: str, | ||
| *, | ||
| cancel_on_disconnect: bool = False, | ||
| stream_mode: Union[StreamMode, Sequence[StreamMode]] = "values", |
There was a problem hiding this comment.
I dont think we should default to anything, as if you dont pass it in you get whatever stream modes you picked when creating the run
There was a problem hiding this comment.
Also the docs should make clear that this list here can only ever be a subset of the one passed to create run
hinthornw
force-pushed
the
wfh/join_stream_mode
branch
from
4047ec2 to
b5a981d
Compare
nfcampos
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.