[3.x] Adds type checking (#1272)

* Adds type checking * Apply fixes from StyleCI * Fixes tests * Update .gitattributes * Update static-analysis.yml --------- Co-authored-by: StyleCI Bot <[email protected]>
laravel · Feb 23, 2023 · 026882b · 026882b
1 parent 4e0e034
commit 026882b
Show file tree

Hide file tree

Showing 6 changed files with 65 additions and 1 deletion.
diff --git a/.gitattributes b/.gitattributes
@@ -14,5 +14,6 @@
 .gitignore export-ignore
 .styleci.yml export-ignore
 CHANGELOG.md export-ignore
+phpstan.neon.dist export-ignore
 phpunit.xml.dist export-ignore
 UPGRADE.md export-ignore
diff --git a/.github/workflows/static-analysis.yml b/.github/workflows/static-analysis.yml
@@ -0,0 +1,41 @@
+name: static analysis
+
+on:
+  push:
+    branches:
+      - master
+      - '*.x'
+  pull_request:
+
+permissions:
+  contents: read
+
+jobs:
+  tests:
+    runs-on: ubuntu-22.04
+
+    strategy:
+      fail-fast: true
+
+    name: Static Analysis
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v3
+
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: 8.2
+          tools: composer:v2
+          coverage: none
+
+      - name: Install dependencies
+        uses: nick-fields/retry@v2
+        with:
+          timeout_minutes: 5
+          max_attempts: 5
+          command: composer update --prefer-stable --prefer-dist --no-interaction --no-progress
+
+      - name: Execute type checking
+        run: vendor/bin/phpstan
diff --git a/composer.json b/composer.json
@@ -24,8 +24,10 @@
     "require-dev": {
         "inertiajs/inertia-laravel": "^0.6.5",
         "laravel/sanctum": "^3.0",
+        "livewire/livewire": "^2.12",
         "mockery/mockery": "^1.0",
         "orchestra/testbench": "^7.0|^8.0",
+        "phpstan/phpstan": "^1.10",
         "phpunit/phpunit": "^9.3"
     },
     "conflict": {

diff --git a/phpstan.neon.dist b/phpstan.neon.dist
@@ -0,0 +1,11 @@
+parameters:
+  paths:
+    - config
+    - database
+    - routes
+    - src
+
+  level: 0
+
+  ignoreErrors:
+    - "#Unsafe usage of new static\\(\\)#"
diff --git a/src/JetstreamServiceProvider.php b/src/JetstreamServiceProvider.php
@@ -74,13 +74,17 @@ public function boot()
         $this->configureCommands();
 
         RedirectResponse::macro('banner', function ($message) {
+            /** @var \Illuminate\Http\RedirectResponse $this */
+
             return $this->with('flash', [
                 'bannerStyle' => 'success',
                 'banner' => $message,
             ]);
         });
 
         RedirectResponse::macro('dangerBanner', function ($message) {
+            /** @var \Illuminate\Http\RedirectResponse $this */
+
             return $this->with('flash', [
                 'bannerStyle' => 'danger',
                 'banner' => $message,

diff --git a/tests/OrchestraTestCase.php b/tests/OrchestraTestCase.php
@@ -5,6 +5,7 @@
 use Laravel\Fortify\FortifyServiceProvider;
 use Laravel\Jetstream\Features;
 use Laravel\Jetstream\JetstreamServiceProvider;
+use Livewire\LivewireServiceProvider;
 use Mockery;
 use Orchestra\Testbench\TestCase;
 
@@ -22,7 +23,11 @@ public function tearDown(): void
 
     protected function getPackageProviders($app)
     {
-        return [JetstreamServiceProvider::class, FortifyServiceProvider::class];
+        return [
+            LivewireServiceProvider::class,
+            JetstreamServiceProvider::class,
+            FortifyServiceProvider::class,
+        ];
     }
 
     protected function defineEnvironment($app)