New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split files based on `/\R+/` regex for `--diff`, same as `--dirty` #339

Merged

taylorotwell merged 1 commit into laravel:main from erikn69:patch-1

Feb 5, 2025

+1 −3

Contributor

erikn69 commented Feb 3, 2025 •

edited

Loading

Fix for [1.x] Adds --diff option #327

/\R+/ matches any type of line break, including:

\n (LF - Unix/Linux)
\r\n (CRLF - Windows)
\r (CR - old macOS)
Other uncommon variations

PREG_SPLIT_NO_EMPTY: Prevents empty elements in the result when consecutive line breaks are found

NOTE: Same as dirty

pint/app/Repositories/GitPathsRepository.php

Line 41 in 7afe4d2

    
           $dirtyFiles = collect(preg_split('/\R+/', $process->getOutput(), flags: PREG_SPLIT_NO_EMPTY))


          Split files based on /\R+/ regex

2b2d79d

parallels999 mentioned this pull request

[1.x] Adds --diff option #327

Merged

erikn69 mentioned this pull request

Test --diff=main aglipanci/laravel-pint-action-demo#25

Merged

taylorotwell merged commit 4182de5 into laravel:main

8 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet