Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to v8 coverage reporter #994

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

jancajthaml
Copy link
Member

No description provided.

@jancajthaml jancajthaml added the enhancement New feature or request label Oct 12, 2024
Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.12%. Comparing base (ef01d33) to head (79bb791).

Additional details and impacted files
@@             Coverage Diff              @@
##              main     #994       +/-   ##
============================================
- Coverage   100.00%   79.12%   -20.88%     
============================================
  Files           31       34        +3     
  Lines          927      910       -17     
  Branches       215      149       -66     
============================================
- Hits           927      720      -207     
- Misses           0       47       +47     
- Partials         0      143      +143     
Flag Coverage Δ
unittests 79.12% <ø> (-20.88%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jancajthaml jancajthaml force-pushed the feature/more-accurate-ut-coverage branch from 6e0ad89 to 619c32c Compare January 22, 2025 18:06
@jancajthaml
Copy link
Member Author

nodejs/node#51251 (comment)

flaky v8 coverage reporter

@jancajthaml
Copy link
Member Author

still issue in v23.6.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant