Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nlb target type option #109

Merged
merged 1 commit into from
Apr 8, 2024
Merged

add nlb target type option #109

merged 1 commit into from
Apr 8, 2024

Conversation

jaxxstorm
Copy link
Member

@jaxxstorm jaxxstorm commented Apr 8, 2024

Ellipsis 🚀 This PR description was created by Ellipsis for commit 822cdbe.

Summary:

This PR introduces a new NlbTargetType option for the Network Load Balancer in the IngressConfig structure across multiple files and SDKs, with a default value of 'ip'.

Key points:

  • Added NlbTargetType option in IngressConfig structure across multiple files.
  • Default value for NlbTargetType is set to 'ip'.
  • Changes reflected in schema.yaml, cluster.go, and SDKs for Go, Python, Node.js, and .NET.

Generated with ❤️ by ellipsis.dev

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me!

  • Reviewed the entire pull request up to 822cdbe
  • Looked at 292 lines of code in 7 files
  • Took 1 minute and 1 seconds to review
More info
  • Skipped 0 files when reviewing.
  • Skipped posting 1 additional comments because they didn't meet confidence threshold of 50%.
1. provider/pkg/provider/cluster.go:31:
  • Assessed confidence : 0%
  • Comment:
    The addition of the NlbTargetType option in the IngressConfig struct is correctly used to set the service.beta.kubernetes.io/aws-load-balancer-nlb-target-type annotation in the Kubernetes service. The changes are consistent across all the SDKs and the default value is correctly set to 'ip'.
  • Reasoning:
    The PR adds a new option for the NLB target type in the IngressConfig struct. This option is then used to set the 'service.beta.kubernetes.io/aws-load-balancer-nlb-target-type' annotation in the Kubernetes service. The changes look correct and there don't seem to be any logical bugs. The default value for the new option is 'ip', which is a valid value for the annotation. The changes are consistent across all the SDKs.

Workflow ID: wflow_7prPsulmsiYB2Znp


Not what you expected? You can customize the content of the reviews using rules. Learn more here.

@jaxxstorm jaxxstorm merged commit 2714a86 into main Apr 8, 2024
14 checks passed
@jaxxstorm jaxxstorm deleted the target_type branch April 8, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant