feat(autoscaling): integrate budget configurations, update Karpenter, and expand SDK support #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellipsis-dev
bot
changed the title
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me!
- Reviewed the entire pull request up to 320b7c8
- Looked at
723lines of code in8files - Took 1 minute and 41 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
0additional comments because they didn't meet confidence threshold of50%.
Workflow ID: wflow_wqWsxufFCqeFdzvT
You can customize Ellipsis with review rules, user-specific overrides, quiet mode, and more. See docs.
There was a problem hiding this comment.
❌ Changes requested.
- Performed an incremental review on 9edf4c6
- Looked at
261lines of code in8files - Took 1 minute and 16 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
0additional comments because they didn't meet confidence threshold of50%.
Workflow ID: wflow_coH1xewu24r6lifr
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with review rules, user-specific overrides, quiet mode, and more. See docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR integrates budget configurations for autoscaled node groups, updates Karpenter, and expands SDK support, enhancing autoscaling functionalities.
Key points:
BudgetConfiginautoscaledNodegroup.go0.36.1incluster.goBudgetConfigschema definitions inschema.yamlBudgetConfigin SDKs for .NET and GoGenerated with ❤️ by ellipsis.dev