feat(provider): add NginxIngressRegistry parameter for Nginx Ingress Controller registry configuration #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellipsis-dev
bot
changed the title
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 3464986 in 38 seconds
More details
- Looked at
227lines of code in6files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_Y8fHqYBuBJIMZQ4T
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -60,6 +60,7 @@ type ClusterArgs struct { | |||
| CertificateArn *pulumi.StringInput `pulumi:"certificateArn"` | |||
There was a problem hiding this comment.
Consider setting a default value for NginxIngressRegistry in the NewCluster function to ensure it has a value even if not provided by the user. This is done for other parameters like ClusterEndpointPrivateAccess and ClusterEndpointPublicAccess.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Introduced
NginxIngressRegistryparameter to specify the container registry for Nginx Ingress Controller, with updates across all language SDKs and schema.Key points:
NginxIngressRegistrytoClusterArgsinprovider/pkg/provider/cluster.go.NginxIngressRegistryisregistry.k8s.io.NewClusterfunction to useNginxIngressRegistryfor Nginx Ingress Controller image registry.schema.yamlwith description and default value.NginxIngressRegistry.Generated with ❤️ by ellipsis.dev