Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

Fix bitwise error when using Extensible Filter #444

Closed
wants to merge 1 commit into from
Closed

Fix bitwise error when using Extensible Filter #444

wants to merge 1 commit into from

Conversation

nickzelei
Copy link

@nickzelei nickzelei commented Jun 20, 2017

This change is fixing an error that occurs when the extensible filter tries to retrieve the value for dnAttributes.

This is reproducible when issuing a search with this filter:

const extFilter = new ldapjs.ExtensibleFilter({
                attribute: "userAccountControl",
                matchType: "userAccountControl",
                rule: "1.2.840.113556.1.4.803",
                value: "2",
                dnAttributes: true
});

ldapClient.search("<base dn>", { filter: extFilter }, (err, res) => { ... });

This will result in the error Expected 0x1: got 0x84

This should fix #430 and #439

Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you able to add a unit test for this?

@jsumners jsumners added the closed-for-v2 Issues that were closed at the release of v2.0.0 but may still need to be addressed. label May 31, 2020
@jsumners jsumners closed this May 31, 2020
@jsumners
Copy link
Member

⚠️ This issue has been locked due to age. If you have encountered a recent
problem that seems to be covered by this issue, please open a new issue.

Please include a minimal reproducible example
when opening a new issue.

@ldapjs ldapjs locked as resolved and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
closed-for-v2 Issues that were closed at the release of v2.0.0 but may still need to be addressed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boolean attributes aren't retrieved when I pull all attributes from LDAP for 1 user
2 participants