[CORELIB-75] DI injected logger #757
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test: Run #2139
🎉 All tests passed!🔄 This comment has been updated |
|
Let's also discuss this internally in a wider group. |
src/CQRS/LeanCode.CQRS.AspNetCore/Middleware/CQRSExceptionTranslationMiddleware.cs
Outdated
Show resolved
Hide resolved
added 5 commits
February 24, 2025 10:01
wojtek2288
force-pushed
the
feature/di-injected-logger
branch
from
3534e20 to
9b3d38a
Compare
jakubfijalkowski
requested changes
Mar 3, 2025
There was a problem hiding this comment.
A couple of changes are needed:
- We must not start
Hostin tests that just configureServiceCollection. This has much more consequences (it really starts a host). - We need to split how we configure the logger, because currently it is very awkward (esp. for tests). We need to leave
ConfigureDefaultLoggeras-is, but we need to introduceAddLeanCodeLoggerthat configures theILogger<T>factory (+ Serilog). - We need
NullLogger<T> - We probably should split the
LeanCode.Loggingpackage into two - one that has the interface (+NullLogger<T>), and the other that has the configuration methods. Now, we have quite unexpected dependencies from e.g. from LeanCode.CQRS.Seciruty to Serilog.Sinks.Console.
|
|
||
| private readonly CQRSMetrics metrics; | ||
| private readonly ISerializer serializer; | ||
| private readonly RequestDelegate next; | ||
|
|
||
| public CQRSMiddleware(CQRSMetrics metrics, ISerializer serializer, RequestDelegate next) | ||
| public CQRSMiddleware( |
There was a problem hiding this comment.
One last (not priority, not mandatory) request - let's put the logger as a last parameter (I think this is also a convention in the .NET examples, but might be wrong here).
Comment on lines
+95
to
+106
| var logger = loggerConfiguration.CreateLogger(); | ||
|
|
||
| if (preserveStaticLogger) | ||
| { | ||
| Log.Logger = logger; | ||
| } | ||
|
|
||
| logging.Services.AddSingleton<Serilog.ILogger>(logger); | ||
| logging.Services.AddSingleton(typeof(ILogger<>), typeof(Logger<>)); | ||
|
|
||
| logging.AddConfiguration(configuration.GetSection(SystemLoggersEntryName)); | ||
| logging.AddSerilog(); | ||
| logging.AddConfiguration(context.Configuration.GetSection(SystemLoggersEntryName)); | ||
| logging.AddSerilog(logger, dispose: true); |
There was a problem hiding this comment.
I think I know why we haven't used AddSerilog in the ConfigureServices, but let's be sure - why?
| serviceCollection.AddScoped<LocalHandlerMiddleware>(); | ||
| serviceCollection.AddScoped<CQRSMetrics>(); | ||
| serviceCollection.AddScoped<ICommandValidatorResolver, CommandValidatorResolver>(); | ||
| var hostBuilder = Host.CreateDefaultBuilder() |
There was a problem hiding this comment.
This is wrong. We don't want to start host here, in any way.
|
|
||
| public StubAuditLogStorage() | ||
| { | ||
| logger = Substitute.For<Logging.ILogger<StubAuditLogStorage>>(); |
There was a problem hiding this comment.
We probably should have a NullLogger<T> implementation. Using NSubstitute for this gives a wrong impression that it is used anyhow.
Comment on lines
+50
to
+59
| private static string GetLogOutput(Action log) | ||
| { | ||
| using var stringWriter = new StringWriter(); | ||
|
|
||
| Console.SetOut(stringWriter); | ||
|
|
||
| log(); | ||
|
|
||
| return stringWriter.ToString(); | ||
| } |
There was a problem hiding this comment.
This will make the test output broken. We can't override console stream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.