Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat; customizable error message on build #105

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

tydeu
Copy link
Collaborator

@tydeu tydeu commented Feb 10, 2025

Adds a Lake configuration option (errorOnBuild) that, when set, will produced a custom error if ProofWidgets needs to be built (and the cache not merely reused). The plan is to use this option in Mathlib in order to advise users to run lake exe cache get instead to get an up-to-date ProofWidgets.

@Vtec234
Copy link
Collaborator

Vtec234 commented Feb 10, 2025

We could add this but I'm wondering, should this maybe be a Lake option, e.g. something you can customize when requireing a package? PW4 is the only mathlib dependency that needs cloud builds right now but I think putting such a requirement might be more generally useful, e.g. for ML packages that come with some prebuilt libraries that downstream should avoid building.

@kim-em
Copy link
Contributor

kim-em commented Feb 11, 2025

I'd propose that we merge as is for now, to get this issue out of the way of Mathlib users (who I think still hit it frequently), and Mac decides when/if a more general fix goes into Lake.

@Vtec234 Vtec234 merged commit 322a050 into leanprover-community:main Feb 12, 2025
3 checks passed
@tydeu tydeu deleted the errorOnBuild branch February 12, 2025 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants