Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable lint in CI #155

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Aesop/Tracing.lean
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ namespace TraceOption
def isEnabled [Monad m] [MonadOptions m] (opt : TraceOption) : m Bool :=
return opt.option.get (← getOptions)

def withEnabled [Monad m] [MonadWithOptions m] (opt : TraceOption) (k : m α) :
m α := do
def withEnabled [MonadWithOptions m] (opt : TraceOption) (k : m α) : m α :=
withOptions (λ opts => opt.option.set opts true) k

initialize steps : TraceOption ←
Expand Down
4 changes: 2 additions & 2 deletions Aesop/Util/Basic.lean
Original file line number Diff line number Diff line change
Expand Up @@ -66,12 +66,12 @@ end PersistentHashSet

-- TODO upstream; generalise to {m : Type u → Type v}.
-- Need to generalise `HashMap.forM` first.
scoped instance {m : Type u → Type u} [BEq α] [Hashable α] [Monad m] :
scoped instance {m : Type u → Type u} [BEq α] [Hashable α] :
ForM m (HashMap α β) (α × β) where
forM | m, f => m.forM λ a b => f (a, b)

-- TODO upstream; generalise to {m : Type u → Type v}.
scoped instance {m : Type u → Type u} [BEq α] [Hashable α] [Monad m] :
scoped instance {m : Type u → Type u} [BEq α] [Hashable α] :
ForIn m (HashMap α β) (α × β) where
forIn := ForM.forIn

Expand Down
4 changes: 2 additions & 2 deletions Aesop/Util/UnorderedArraySet.lean
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ protected def ofSortedArray (xs : Array α) : UnorderedArraySet α :=

set_option linter.unusedVariables false in
/-- O(n*log(n)) -/
protected def ofArray [ord : Ord α] [Inhabited α] (xs : Array α) :
protected def ofArray [ord : Ord α] (xs : Array α) :
UnorderedArraySet α :=
⟨xs.sortDedup⟩

Expand Down Expand Up @@ -91,7 +91,7 @@ def foldM [Monad m] (f : σ → α → m σ) (init : σ) (s : UnorderedArraySet
m σ :=
s.rep.foldlM f init

instance [Monad m] : ForIn m (UnorderedArraySet α) α where
instance : ForIn m (UnorderedArraySet α) α where
forIn s := s.rep.forIn

/-- O(n) -/
Expand Down
2 changes: 2 additions & 0 deletions lakefile.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
name = "aesop"
defaultTargets = ["Aesop"]
testDriver = "AesopTest"
lintDriver = "batteries/runLinter"
lintDriverArgs = ["Aesop"]
precompileModules = false # We would like to turn this on, but it breaks the Mathlib cache.

[[require]]
Expand Down
Loading