This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
refactor(number_theory/modular_forms/slash_actions): slash actions are families of distrib_mul_action
s
#18932
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the bespoke
slash_action β G α γ
typeclass with:Π b : β, distrib_mul_action (slash_act G b) α
for the action itself, whereslash_act G b
is a type alias ofmul_opposite
(to allow for right actions)smul_comm_class (slash_act G k) γ α
for compatibility with theγ
actionThis means compatibility with multiple types simultaneously is possible, and that
f ∣[k;γ] A
notation can be discarded.This keeps around
slash_action.map k A f
to providef ∣[k] A
notation, but it's now reducibly equal toslash_act.of k A • f
It's not immediately clear that the switch to using
distrib_mul_action
is worth it, but this does at least prove it can be done.