Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(AlgebraicGeometry/EllipticCurve/*): remove redundant names #22479

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Multramate
Copy link
Collaborator

Clean up a few redundant/bad names:

  • nonsingular_zero_of_Δ_ne_zero is a special case of nonsingular_of_Δ_ne_zero, which itself is a (very easy) special case of equation_iff_nonsingular_of_Δ_ne_zero, and similarly with nonsingular and equation_iff_nonsingular
  • equation_neg(_of) and nonsingular_neg(_of) are special cases of equation_neg_iff and nonsingular_neg_iff
  • mapFun and toClassFun are function versions of the group homomorphisms map and toClass
  • mk_XYIdeal'_mul_mk_XYIdeal'_of_Yeq should have been named mk_XYIdeal'_neg_mul according to naming conventions
  • all instance names since they can be named automatically

Open in Gitpod

Copy link

github-actions bot commented Mar 2, 2025

PR summary a4f6c76f37

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ equation_iff_nonsingular
+ equation_iff_nonsingular_of_Δ_ne_zero
+ instance : AddZeroClass W.Point
+ mk_XYIdeal'_neg_mul
++ instance : Neg W.Point
++ instance [Nontrivial R] : Zero W'.Point
+++ instance : Add W.Point
- instAddZeroClassPoint
- of
-- instNegPoint
-- instZeroPoint
--- instAddPoint

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-algebraic-geometry Algebraic geometry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant