-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: split long file Mathlib.Data.Set.Basic #22484
base: master
Are you sure you want to change the base?
Conversation
Will need a |
PR summary 1ebb7babaeImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> The doc-module for Decrease in tech debt: (relative, absolute) = (1.00, 0.03)
Current commit 1ebb7babae You can run this locally as
|
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was hoping we could make some gains on the import structure: did you see a way to reduce the imports required for Data.Set.Basic
, or is this pretty much the best we can do?
Co-authored-by: Anne Baanen <[email protected]>
Co-authored-by: Anne Baanen <[email protected]>
…hlib4 into split_set_basic
There's not much below We could probably get GaloisConnections.Defs and Order.Monotone out of the way? Not sure how valuable that would be. |
No description provided.