Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Data/Multiset): redistribute Nodup material #22502

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Vierkantor
Copy link
Contributor

Now that Multiset.Nodup lives in Multiset/Defs.lean, all the material on Nodup in Nodup.lean can be upstreamed to other files in the Multiset folder. We are left with Pairwise.forall which doesn't mention Nodup at all, so I renamed the file to Pairwise.lean. (Note that Git decided it is a deletion + addition, not a rename...)

Source of the Pairwise.lean attribution: leanprover-community/mathlib3#569


Open in Gitpod

Now that `Multiset.Nodup` lives in `Multiset/Defs.lean`, all the material on `Nodup` in `Nodup.lean` can be upstreamed to other files in the `Multiset` folder. We are left with `Pairwise.forall` which doesn't mention `Nodup` at all, so I renamed the file to `Pairwise.lean`. (Note that Git decided it is a deletion + addition, not a rename...)
@Vierkantor Vierkantor added awaiting-CI t-data Data (lists, quotients, numbers, etc) labels Mar 3, 2025
Copy link

github-actions bot commented Mar 3, 2025

PR summary 1fca12ecaf

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Data.Multiset.Nodup 383 0 -383 (-100.00%)
Mathlib.Data.Finset.Empty 385 366 -19 (-4.94%)
Mathlib.Data.Finset.Attach 385 376 -9 (-2.34%)
Mathlib.Data.Finset.Erase 385 377 -8 (-2.08%)
Mathlib.Data.Finset.Filter 386 378 -8 (-2.07%)
Mathlib.Data.Multiset.Dedup 385 382 -3 (-0.78%)
Mathlib.Data.Multiset.Sum 400 397 -3 (-0.75%)
Mathlib.Data.Finset.Range 396 394 -2 (-0.51%)
Mathlib.Data.Multiset.Powerset 452 451 -1 (-0.22%)
Import changes for all files
Files Import difference
There are 4205 files with changed transitive imports taking up over 183983 characters: this is too many to display!
You can run scripts/import_trans_difference.sh all locally to see the whole output.

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

maintainer merge

Copy link

github-actions bot commented Mar 3, 2025

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge t-data Data (lists, quotients, numbers, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants