Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CategoryTheory): fix hasLimitOfIso #22514

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

joelriou
Copy link
Collaborator

@joelriou joelriou commented Mar 3, 2025

hasLimitOfIso is renamed hasLimit_of_iso. A new lemma hasLimit_iff_of_iso is added.


Open in Gitpod

@joelriou joelriou added the t-category-theory Category theory label Mar 3, 2025
Copy link

github-actions bot commented Mar 3, 2025

PR summary 9bc2879727

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ hasColimit_iff_of_iso
+ hasColimit_of_iso
+ hasLimit_iff_of_iso
+ hasLimit_of_iso
+ instance : HasCoproduct (op <| Z ·) := hasColimit_of_iso
+ instance : HasProduct (op <| Z ·) := hasLimit_of_iso
- instance : HasCoproduct (op <| Z ·) := hasColimitOfIso
- instance : HasProduct (op <| Z ·) := hasLimitOfIso

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-category-theory Category theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant