Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Logic.Hydra #2290

Closed
wants to merge 12 commits into from
Closed

[Merged by Bors] - feat: port Logic.Hydra #2290

wants to merge 12 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Feb 14, 2023

Open in Gitpod

urkud added 5 commits February 14, 2023 17:26
@urkud
feat: port Logic.Hydra
a82d304
@urkud
Initial file copy from mathport
105421c
@urkud
automated fixes
33052cc 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@urkud
Snapshot
ece766b
@urkud
Fix
7b0aea6
@kim-em kim-em added awaiting-author A reviewer has asked the author a question or requested changes merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) labels Mar 29, 2023
@int-y1 int-y1 added the mathlib-port This is a port of a theory file from mathlib. label Apr 3, 2023
@kim-em kim-em removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 3, 2023
@int-y1 int-y1 added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes labels Apr 3, 2023
kim-em
kim-em reviewed Apr 3, 2023
View reviewed changes
Mathlib/Logic/Hydra.lean Outdated
convert (add_zero _).symm
exact count_eq_zero.2 fun ha => hi.irrefl a <| hr a ha
refine ⟨a, fun b h ↦ ?_, ?_⟩ <;> simp_rw [toFinsupp_apply]
· replace he := congr_arg (count b) he -- porting note: was apply_fun count b at he
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, apply_fun has been improved in the meantime, and works here. (Also a few lines below.)

@ChrisHughes24
Copy link
Member

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Apr 3, 2023
bors bot pushed a commit that referenced this pull request Apr 3, 2023
@urkud @int-y1
@kim-em @ChrisHughes24
feat: port Logic.Hydra (#2290)
59e4a79 
Co-authored-by: Jason Yuen <[email protected]>
Co-authored-by: int-y1 <[email protected]>
Co-authored-by: Scott Morrison <[email protected]>
Co-authored-by: ChrisHughes24 <[email protected]>
@bors
Copy link

bors bot commented Apr 3, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Logic.Hydra [Merged by Bors] - feat: port Logic.Hydra Apr 3, 2023
@bors bors bot closed this Apr 3, 2023
@bors bors bot deleted the port/Logic.Hydra branch April 3, 2023 11:59
MonadMaverick pushed a commit that referenced this pull request Apr 9, 2023
@urkud @int-y1
@kim-em @ChrisHughes24 @MonadMaverick
feat: port Logic.Hydra (#2290)
54ada36 
Co-authored-by: Jason Yuen <[email protected]>
Co-authored-by: int-y1 <[email protected]>
Co-authored-by: Scott Morrison <[email protected]>
Co-authored-by: ChrisHughes24 <[email protected]>
MonadMaverick pushed a commit to MonadMaverick/mathlib4 that referenced this pull request Apr 9, 2023
@urkud @int-y1
@kim-em @ChrisHughes24 @MonadMaverick
feat: port Logic.Hydra (leanprover-community#2290)
500ab3f 
Co-authored-by: Jason Yuen <[email protected]>
Co-authored-by: int-y1 <[email protected]>
Co-authored-by: Scott Morrison <[email protected]>
Co-authored-by: ChrisHughes24 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim-em kim-em kim-em left review comments

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@urkud @ChrisHughes24 @kim-em @int-y1