-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make structure
command elaborate as if structures are flat
#7302
Draft
kmill
wants to merge
12
commits into
leanprover:master
Choose a base branch
from
kmill:work_on_structure2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+873
−422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
structure
command elaborate fields like structures are flat
24c575c
to
ac961b5
Compare
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Mar 3, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 3, 2025
structure
command elaborate fields like structures are flatstructure
command elaborate as if structures are flat
Mathlib CI status (docs):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaks-mathlib
This is not necessarily a blocker for merging: but there needs to be a plan
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read this section before submitting
missing documentation
ormissing tests
then it needs fixing!RFC
orbug
issue in the description.feat/fix
PRs, the first paragraph starting with "This PR" must be present and will become achangelog entry unless the PR is labeled with
no-changelog
. If the PR does not have this label,it must instead be categorized with one of the
changelog-*
labels (which will be done by areviewer for external PRs).
leanprover/lean4-pr-releases:pr-release-NNNN
for Linux and M-series Macs will be generated upon build. To generate binaries for Windows and Intel-based Macs as well, write a comment containingrelease-ci
on its own line.nightly-with-mathlib
then CI will test Mathlib against your PR.awaiting-review
,awaiting-author
, andWIP
labels yourself, by writing a comment containing one of these labels on its own line.---
before submitting.This PR <short changelog summary for feat/fix, see above>.
Closes <
RFC
orbug
issue number fixed by this PR, if any>