Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly collect let-rec fvars through delayed-assigned mvar #7304

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: correctly collect let-rec fvars through delayed-assigned mvar #7304

wants to merge 1 commit into from

Conversation

jrr6
Copy link
Contributor

@jrr6 jrr6 commented Mar 3, 2025

This PR fixes an issue where nested let rec declarations within match expressions or tactic blocks failed to compile if they were nested within, and recursively called, a let rec that referenced a variable bound by a containing declaration.

Closes #6927

@jrr6 jrr6 added the changelog-language Language features, tactics, and metaprograms label Mar 3, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Mar 3, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Mar 3, 2025 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 2377f3542622e24dd1ad1ee49a20ea14e34f34d3 --onto e3c6909ad593e5a966a449df5e92abb1f0dbc317. (2025-03-03 16:28:34)
  • ✅ Mathlib branch lean-pr-testing-7304 has successfully built against this PR. (2025-03-03 17:45:25) View Log

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Mar 3, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#7304
e670fba
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Mar 3, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#7304
f63e4b1
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Mar 3, 2025
@jrr6 jrr6 marked this pull request as ready for review March 3, 2025 18:41
@jrr6 jrr6 requested a review from nomeata March 3, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nomeata nomeata Awaiting requested review from nomeata

Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR changelog-language Language features, tactics, and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unknown free variable '_fvar.639'
2 participants
@jrr6 @leanprover-community-bot