Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: never transfer constants from checked environment into elab branches #7306

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: never transfer constants from checked environment into elab branches #7306

wants to merge 1 commit into from

Conversation

Kha
Copy link
Member

@Kha Kha commented Mar 3, 2025

Otherwise we may lose the environment extension state of the constant

@Kha Kha added the changelog-no Do not include this PR in the release changelog label Mar 3, 2025
@Kha
Copy link
Member Author

Kha commented Mar 3, 2025

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 9faeefb.
The entire run failed.
Found no significant differences.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Mar 3, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase a244b0688244a0b9036fc2f14e63c1368bbdd94c --onto e3c6909ad593e5a966a449df5e92abb1f0dbc317. (2025-03-03 17:40:11)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changelog-no Do not include this PR in the release changelog toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kha @leanprover-bot @leanprover-community-bot