Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vcomlink test #1016

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Add vcomlink test #1016

wants to merge 3 commits into from

Conversation

shjala
Copy link
Member

@shjala shjala commented Aug 21, 2024

This is a test for lf-edge/eve#4142, but I don't know which one should go first ?!

tests/vcom/base.go Outdated Show resolved Hide resolved
pkg/remote/utils.go Outdated Show resolved Hide resolved
pkg/remote/utils.go Outdated Show resolved Hide resolved
pkg/remote/utils.go Outdated Show resolved Hide resolved
@milan-zededa
Copy link
Contributor

This is a test for lf-edge/eve#4142, but I don't know which one should go first ?!

If this test depends on the EVE PR and would fail until it is merged and released, then this PR should wait.
I typically mark such eden PR as draft until there is EVE version with the tested functionality available. Then I update DefaultEVETag in pkg/defaults as part of the PR and mark it as ready for review.

@shjala shjala marked this pull request as draft August 22, 2024 10:20
@shjala
Copy link
Member Author

shjala commented Aug 22, 2024

If this test depends on the EVE PR and would fail until it is merged and released, then this PR should wait.

Yeah, I get it. But it is a conundrum, how I can show that my PR in eve works fine without merging this test, and on the other hand merging this breaks the eden tests.

@shjala shjala force-pushed the vcom_eden_test branch 2 times, most recently from 8d0c3d5 to 06b9eac Compare August 22, 2024 16:23
@shjala shjala mentioned this pull request Aug 23, 2024
4 tasks
@shjala shjala changed the title add vcomlink test [WIP] add vcomlink test Aug 26, 2024
@shjala shjala force-pushed the vcom_eden_test branch 2 times, most recently from e27c64d to 9962754 Compare August 29, 2024 16:26
@shjala shjala marked this pull request as ready for review September 2, 2024 08:46
@shjala shjala changed the title [WIP] add vcomlink test add vcomlink test Sep 2, 2024
@shjala
Copy link
Member Author

shjala commented Sep 2, 2024

This is ready to be merge as soon as we get the new eve release.

@shjala shjala force-pushed the vcom_eden_test branch 5 times, most recently from f71d237 to 1fd58e3 Compare September 4, 2024 07:35
@shjala shjala marked this pull request as draft September 4, 2024 09:03
@shjala shjala self-assigned this Sep 4, 2024
@shjala shjala changed the title add vcomlink test Add vcomlink test Sep 4, 2024
This is a test for EVE PR #4142.

Signed-off-by: Shahriyar Jalayeri <[email protected]>
Signed-off-by: Shahriyar Jalayeri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants