Add virtualization workflow with no TPM #1025
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to test deploying container-in-VM to a device without TPM. In the past we had some bug merged because this was not tested. Also, it is better to use string attributes for workflow matrix, even for the boolean tpm option. Then instead of workflow names: eden-report-smoke.tests.txt-tpm-true-ext4 eden-report-smoke.tests.txt-tpm-false-zfs We get somewhat more readable eden-report-smoke.tests.txt-tpm-ext4 eden-report-smoke.tests.txt-no-tpm-zfs I'm open for one-word suggestions to replace "no-tpm". What EVE uses when TPM is not available? Golang crypto library? Should we call it gocrypto? I don't know. Signed-off-by: Milan Lenco <[email protected]>
|
Names of artifacts are not what I have hoped for, moving to draft.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to test deploying container-in-VM to a device without TPM. In the past we had some bug merged because this was not tested. Also, it is better to use string attributes for workflow matrix, even for the boolean tpm option.
Then instead of workflow names:
We get somewhat more readable:
I'm open for one-word suggestions to replace "no-tpm". What EVE uses when TPM is not available? Golang crypto library? Should we call it "gocrypto"? I don't know.