add eve_log_level parameter to GH test workflow #1033
Conversation
|
But how would you execute a workflow with debug log level in EVE? You want to introduce manual eden test run action? |
No, I would just set it for the existing eden test workflow for every PR. Like this lf-edge/eve#4381 |
.github/workflows/test.yml
Outdated
| eve_log_level: | ||
| type: string | ||
| required: false | ||
| default: 'info' |
There was a problem hiding this comment.
Before using this from the eve repo, we should try to set 'debug' first here.
We need to check how large the output artifacts will be and whether they are not exceeding some github limits.
There was a problem hiding this comment.
I couldn't find any official documentation on the topic, but there is a rumor that the limit is 5 GB per file.
Our artifacts still stay under 50 MB https://github.com/lf-edge/eden/actions/runs/11437464614?pr=1033
There was a problem hiding this comment.
Here are the before and after screenshots. I'd say the sizes stay comparable.
There was a problem hiding this comment.
Does it actually work?
When I look for example into https://github.com/lf-edge/eden/actions/runs/11437464614/artifacts/2081755978,
I do not see debug logs inside eve-info.tar.gz
debug.default.loglevel is configured to info in persist-status/zedagent/ConfigItemValueMap/global.json
There was a problem hiding this comment.
Sorry, I just noticed that as well 🤦
Will fix very soon
There was a problem hiding this comment.
ok, now I think I got it right
the sizes have increased but still not dramatic
There was a problem hiding this comment.
maybe we can try running it like this for a while and if we reach some limit we can still revert it
There was a problem hiding this comment.
btw github copilot can provide some interesting insights that cannot be found in the github documentation
I'm just wondering if it's true or hallucinations 😄
europaul
force-pushed
the
eve-log-level-workflow-parameter
branch
2 times, most recently
from
726ea06
to
c1481dd
Compare
|
folks, could you give this PR another look? I think I answered all the comments and fixed the issues. |
There was a problem hiding this comment.
LGTM and I would suggest to keep set log-level to debug for all tests so that we have more logs also here in the eden repo. Just revert the last commit.
It would be useful to be able to set the log level for EVE when running tests, as e.g. "debug" log level would provide more information for debugging failed tests. It would be good to include this change in the next release of Eden, so that it can be used workflows started from EVE repository. Signed-off-by: Paul Gaiduk <[email protected]>
This commit is used for testing the workflow parameter for the log-level It will be reverted before merging Signed-off-by: Paul Gaiduk <[email protected]>
europaul
force-pushed
the
eve-log-level-workflow-parameter
branch
from
a44c42b
to
aa55191
Compare
It would be useful to be able to set the log level for EVE when running tests, as e.g. "debug" log level would provide more information for debugging failed tests.
It would be good to include this change in the next release of Eden, so that it can be used workflows started from EVE repository.